search

vmware-archive / wavefront-adapter-for-istio

Wavefront by VMware Adapter for Istio is an adapter for Istio to publish metrics to Wavefront by VMware.
Other
14 stars 17 forks source link

Report default adapter metrics every 60sec. #102

Closed akodali18 closed 4 years ago

akodali18 commented 4 years ago

Description {{ Succinctly describe your change }}

Additional context {{ Add any other context about the change here, for example, Fixes #issue-number }}

akodali18 commented 4 years ago

I'm wondering if these should be based on the flushInterval.

This is just the default interval for now to get this fix out sooner. We will make this reporting interval configurable in the next change and then the adapter and wavefront reporting intervals will be based off of that. Then users would be able to fine tune by setting both reporting interval as well as flush interval based on their needs.

akodali18 commented 4 years ago

In general, i meant to say updating those metrics in internal registry frequently might not be needed , since we don't write to buffer until reporting interval is elapsed.