search

vmware-archive / wavefront-adapter-for-istio

Wavefront by VMware Adapter for Istio is an adapter for Istio to publish metrics to Wavefront by VMware.
Other
14 stars 17 forks source link

Migrating to Go Modules from Glide #72

Closed ankurdh closed 5 years ago

ankurdh commented 5 years ago

Description

NOTE: Please enable GO111MODULE by running

export GO111MODULE=on

Without this, go modules are disabled for use in the GOPATH.

Additional context

Testing

$ make test
go build -v ./...
cp wavefront/config/wavefront.yaml install/wavefront/templates/
Build was successful!
go test -v ./...
?       github.com/vmware/wavefront-adapter-for-istio/wavefront [no test files]
?       github.com/vmware/wavefront-adapter-for-istio/wavefront/cmd [no test files]
=== RUN   TestMetricInfo
--- PASS: TestMetricInfo (0.00s)
=== RUN   TestValidateCredentials
--- PASS: TestValidateCredentials (0.00s)
=== RUN   TestValidateMetrics
--- PASS: TestValidateMetrics (0.00s)
=== RUN   TestValidateMetricsDuplicate
--- PASS: TestValidateMetricsDuplicate (0.00s)
PASS
ok      github.com/vmware/wavefront-adapter-for-istio/wavefront/config  0.007s

Fixes #54

vmwclabot commented 5 years ago

@ankurdh, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

venilnoronha commented 5 years ago

Since we're leveraging Go v1.12.1, could you update the parts about GO111MODULE in the PR description?

vmwclabot commented 5 years ago

@ankurdh, VMware has approved your signed contributor license agreement.

ankurdh commented 5 years ago

Since we're leveraging Go v1.12.1, could you update the parts about GO111MODULE in the PR description?

I don't follow fully. What should I change?

venilnoronha commented 5 years ago

I don't follow fully. What should I change?

Actually, let's leave it as is. I initially thought that the flag was specific to Go v1.11.