vmware-archive / wavefront-adapter-for-istio

Wavefront by VMware Adapter for Istio is an adapter for Istio to publish metrics to Wavefront by VMware.
Other
14 stars 17 forks source link

Alternate namespaces #70 #76

Closed dlinsley closed 5 years ago

dlinsley commented 5 years ago

Description Changes to make namespace configurable for this adapter.

The adapter would not function if the handler, rule and adapter objects were outside of the istio-system namespace. The naming of these objects though is unique enough at the moment to prevent naming conflicts with other Istio adapters.

Additional context This change is functional with helm template style of installation. It will not work with helm install since there is more than one namespace involved.

This change works in the event that other Istio adapters are installed on the same Kubernetes cluster and they use the same metric or instance names. With this change the instance objects can be in a different namespace specific for this adapter.

Feedback welcome!

Fixes #70