vmware-archive / wavefront-adapter-for-istio

Wavefront by VMware Adapter for Istio is an adapter for Istio to publish metrics to Wavefront by VMware.
Other
14 stars 17 forks source link

In the default Helm values.yaml file, don't provide `direct:` configuration. #84

Open dmaze opened 4 years ago

dmaze commented 4 years ago

Description

Comment out the direct: configuration block in the default Helm values.yaml file.

Additional context

This is hard to disable as a downstream consumer if you have an in-cluster proxy; since there winds up being both direct: and proxy: configuration the proxy tries to send directly to Wavefront, which isn't actually correctly configured.

This PR is very similar to #75 (which addresses #73) but that got undone in #79.