search

vmware-archive / wavefront-adapter-for-istio

Wavefront by VMware Adapter for Istio is an adapter for Istio to publish metrics to Wavefront by VMware.
Other
14 stars 17 forks source link

INT-524 update istio adapter to use the latest go-metrics package #90

Closed baburajvelayudhan closed 4 years ago

baburajvelayudhan commented 4 years ago

Description go.mod updated to use the latest go-metrics package.

  1. Changes in wavefront.go and system_stats.go to use the new reporter.

Additional context {{ Add any other context about the change here, for example, Fixes #issue-number }}

vmwclabot commented 4 years ago

@baburajvelayudhan, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

baburajvelayudhan commented 4 years ago

all comments incorporated

baburajvelayudhan commented 4 years ago

closing the pull request since https://github.com/vmware/wavefront-adapter-for-istio/pull/93 addresses all the suggested comments/ issues