search

vmware-archive / wavefront-django-sdk-python

Apache License 2.0
2 stars 3 forks source link

Remove imports and instantiation from settings.py #4

Closed AgDude closed 5 years ago

AgDude commented 5 years ago

Move reporter and tracer instantiation out of settings.py and into AppConfig.ready Prefix all settings with WF Update tracing class to instantiate default tracer automatically

AgDude commented 5 years ago

I see this has entered the review process, so I will leave it open and welcome feedback, but as I have worked with this for a couple of days, I think it adds too much complexity. I am going to try a different approach, which will not rely on the AppConfig.

The current instructions for this project suggest adding this to INSTALLED_APPS, but before this pull request I think that is not required, and it would be preferable to keep it that way. Also note that the opentracing-contrib django implementation also does not require an installed app.

AgDude commented 5 years ago

Please consider #8 instead of this pull request.