search

vmware-archive / xenon

Xenon - Decentralized Control Plane Framework
Other
227 stars 97 forks source link

remove verbose log msg from NodeGroupService #25

Closed georgechrysanthakopoulos closed 7 years ago

georgechrysanthakopoulos commented 7 years ago

see https://github.com/vmware/xenon/commit/9f89a27508821116a6f4c6fcd303861485c87e2a

fyi @ttddyy @toliaqat @asafka

toliaqat commented 7 years ago

We have sometimes used these log messages to detect possible conflict in the node group state between nodes. It has helped to find which node is not able to agree on the version of the node-group state with other nodes.

For this reason, I would suggest that we keep this log as it is.

georgechrysanthakopoulos commented 7 years ago

any updates on this?

asafka commented 7 years ago

I don't find this message valuable either. @toliaqat do you find this specific message helpful?

toliaqat commented 7 years ago

These logs are annoying most of the time but were the only way to debug/detect gossip problems in past.

toliaqat commented 7 years ago

I suggest that we go the route of fixing this off-by-one version between node status entries.