vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.
https://clarity.design
MIT License
163 stars 42 forks source link

Datalist control does not respect clrLabelSize value above 2 in horizontal or compact layouts #128

Closed arcmodo closed 2 years ago

arcmodo commented 2 years ago

Describe the bug

When specifying clrLabelSize > 2 in a compact or horizontal layout, the datalist component is ignoring clrLabelSize.

How to reproduce

Clarity Angular v13 and Core v6 Stackblitz.

Steps to reproduce the behavior:

  1. In a basic Clarity Core/Angular app, set your form clrLayout="compact", "horizontal" or default and clrLabelSize="4"
  2. Add various controls such as input, select, etc., but be sure to include the datalist control
  3. All controls will properly respect clrLabelSize="4" for layout, except for the datalist control

Expected behavior

The datalist control should respect the clrLabelSize value of 4

Versions

Clarity project:

Clarity version:

Framework:

Framework version: Angular v13

Device:

Additional notes

This is an issue in Edge 103 and Chrome 103. Note from one of our developers, "I noticed in Clarity source code that the label columns were increased from 2 to 4 for most of the form controls except the datalist. Before the change, label was given 2 columns width and form control 10 columns. After the change, it is label 4 columns and form control 8 columns, except for datalist which appears to remain at 2 columns."

image

ashleyryan commented 2 years ago

Clarity Core has no knowledge of clr/ui (the clr prefix you're mentioning). It does not, and will not, respect Clarity NG or Clr/ui properties. It's recommended to switch your whole form to Core, if something isn't working as expected

github-actions[bot] commented 2 years ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.