fix(tag): remove hover bg color change when disabled

vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.

https://clarity.design

MIT License

163 stars 42 forks source link

fix(tag): remove hover bg color change when disabled #135

Closed ashleyryan closed 2 years ago

ashleyryan commented 2 years ago

fixes #134

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

When hovering over a disabled clickable tag, the background color still changes

Issue Number: #134

What is the new behavior?

The background color no longer changes on hover, when disabled

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

github-actions[bot] commented 2 years ago

👋 @ashleyryan,

🙏 The Clarity team thanks you for opening a pull request
🎉 The build for this PR has succeeded
🔍 The PR is now ready for review
🍿 In the meantime, checkout out a preview of this PR
🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

ashleyryan commented 2 years ago

Hey @colinreedmiller I'm not sure if you want to review this: https://135--storybook-core-clarity-design.netlify.app/?path=/story/components-tag--page (scroll down to clickable tags and you'll see two rows of disabled tags). I made an assumption that we don't want to change the background color on colored tags on hover when they're disabled, can you confirm?

colinreedmiller commented 2 years ago

@ashleyryan Thanks for looping me in. This change implements the correct behavior.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 6.1.1 :tada:

The release is available on:

GitHub release
v6.1.1

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.