vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.
https://clarity.design
MIT License
163 stars 42 forks source link

Alert web component does not detect the overflow in some cases #137

Closed Alienah closed 2 years ago

Alienah commented 2 years ago

Describe the bug

We are using the alert component in my team and we have encountered a problem. The content that we are introducing inside the slot has overflow, however the web component does not seem to detect it and therefore allow the scroll to be activated.

How to reproduce

Here we see an example using the same content inside the web component and outside the web component. We can see that in the second example (outside the web component) a scroll bar is displayed. That is the desired behaviour.

https://stackblitz.com/edit/clarity-javascript-demo-sjwgpi?file=src%2Findex.html

Steps to reproduce the behavior:

  1. Go to the index
  2. See the example showing a code content inside the alert box and outside the alert box

image

Expected behavior

We can see that in the second example (outside the web component) a scroll bar is displayed. That is the desired behaviour.

image

Versions

Clarity project:

Clarity version:

Framework:

Framework version: Vanilla Javascript and HTML

Device:

Additional notes

Add any other notes about the problem here.

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 5.8.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 6.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.