vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.
https://clarity.design
MIT License
163 stars 42 forks source link

fix: upgrade lit-labs/react version #152

Closed ashleyryan closed 2 years ago

ashleyryan commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Upgrades to the latest version of lit-labs/react, and includes a fix for #151

What is the new behavior?

Fixes property accessors (props with get/set) in react. Adds a unit test for the disabled="false" issue

Does this PR introduce a breaking change?

Other information

github-actions[bot] commented 2 years ago

πŸ‘‹ @ashleyryan,

Thank you,

πŸ€– Clarity Release Bot

ashleyryan commented 2 years ago

@kevinbuhmann yeah i don't entirely understand them either, I think it has to do with some of the changes with how lit treats properties. I before the snapshot happens before the lit elements have finished running and can sync properties back to attributes. The snapshots are mostly useless, a holdover from the previous tests using Enzyme, but are good quick check when changing code. I took a quick glance in react and the components all looked fine

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 6.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

Hi there πŸ‘‹, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.