Closed ashleyryan closed 2 years ago
π @ashleyryan,
Thank you,
π€ Clarity Release Bot
@kevinbuhmann yeah i don't entirely understand them either, I think it has to do with some of the changes with how lit treats properties. I before the snapshot happens before the lit elements have finished running and can sync properties back to attributes. The snapshots are mostly useless, a holdover from the previous tests using Enzyme, but are good quick check when changing code. I took a quick glance in react and the components all looked fine
:tada: This PR is included in version 6.1.2 :tada:
The release is available on:
v6.1.2
Your semantic-release bot :package::rocket:
Hi there π, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Upgrades to the latest version of lit-labs/react, and includes a fix for #151
What is the new behavior?
Fixes property accessors (props with get/set) in react. Adds a unit test for the disabled="false" issue
Does this PR introduce a breaking change?
Other information