vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.
https://clarity.design
MIT License
163 stars 42 forks source link

fix(dropdown): react - dont pass hidden prop to cds-dropdown when false #154

Closed ashleyryan closed 2 years ago

ashleyryan commented 2 years ago

This is the boolean attribute issue that also effected modals as well. Passing in a false value renders hidden="false" in the DOM, which is breaking the overlay layer logic

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

The dropdown isn't closing when clicking outside of the dropdown.

Issue Number: #150

What is the new behavior?

React no longer renders a value for hidden, so the dropdown works as execpted

Does this PR introduce a breaking change?

Other information

github-actions[bot] commented 2 years ago

👋 @ashleyryan,

Thank you,

🤖 Clarity Release Bot

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 6.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.