vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.
https://clarity.design
MIT License
163 stars 42 forks source link

fix(range): update track width when value is changed programmatically #158

Closed ashleyryan closed 2 years ago

ashleyryan commented 2 years ago

fixes #157

the input event doesn't fire when the value is changed in code, so listen for the property change

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

When the value is changed in react (or via the .value property in vanilla js) the track width is not updating.

Issue Number: #157

What is the new behavior?

The component listens to the property change and updates the track width, since the input event doesn't fire in that case.

Does this PR introduce a breaking change?

Other information

github-actions[bot] commented 2 years ago

👋 @ashleyryan,

Thank you,

🤖 Clarity Release Bot

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 6.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.