vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.
https://clarity.design
MIT License
163 stars 42 forks source link

fix(textarea): update disabled text color #167

Closed ashleyryan closed 2 years ago

ashleyryan commented 2 years ago

fixes #165

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

The text color in a disabled textarea didn't match the color of other disabled elements

Issue Number: #165

What is the new behavior?

The color now matches the color of other disabled inputs

image

Does this PR introduce a breaking change?

Other information

github-actions[bot] commented 2 years ago

👋 @ashleyryan,

Thank you,

🤖 Clarity Release Bot

ashleyryan commented 2 years ago

The color contrast of this doesn't pass, but I believe that the spec doesn't require disabled inputs to have the appropriate contrast?

colinreedmiller commented 2 years ago

The color contrast of this doesn't pass, but I believe that the spec doesn't require disabled inputs to have the appropriate contrast?

Correct. No contrast requirement for disabled items.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 6.1.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.