Open ambar-arkin opened 1 year ago
@colinreedmiller Please review proposed fix here: https://www.figma.com/file/ZxpTBCvcpjEmR4MaBjEns8/GH%23169---App-level-alert-text-alignment?node-id=102%3A34&t=mDZ5nxi3I7yLTgGq-1
Sorry for the label and assignee churn above. I see now that the visual design still needs review.
Describe the bug
The alert close button is not centered. It has more space below it than above.
How to reproduce
This can be observed in any storybook example. https://storybook.core.clarity.design/?path=/story/components-alert-banner--page
Expected behavior
It should be centered.
Versions
Clarity project:
Clarity version:
Framework:
Framework version: React 16.14.0
Device:
Additional notes
display: inline-flex;
tocds-internal-close-button
element.Is there any way to fix this in userland till this is fixed? Willing to contribute if this is not a priority for the clarity team right now.
Edit:
As a temporary fix I can pass
--cds-global-space-9: 20px
to the component. But not sure if it would break anything else.