vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.
https://clarity.design
MIT License
163 stars 42 forks source link

Alert banner close button is not vertically centered #169

Open ambar-arkin opened 1 year ago

ambar-arkin commented 1 year ago

Describe the bug

The alert close button is not centered. It has more space below it than above.

How to reproduce

This can be observed in any storybook example. https://storybook.core.clarity.design/?path=/story/components-alert-banner--page

image

Expected behavior

It should be centered.

Versions

Clarity project:

Clarity version:

Framework:

Framework version: React 16.14.0

Device:

Additional notes

Is there any way to fix this in userland till this is fixed? Willing to contribute if this is not a priority for the clarity team right now.

Edit:

As a temporary fix I can pass --cds-global-space-9: 20px to the component. But not sure if it would break anything else.

colinreedmiller commented 1 year ago

https://vmware.slack.com/archives/C0JF8D2LB/p1663842654580049

lil-kim commented 1 year ago

@colinreedmiller Please review proposed fix here: https://www.figma.com/file/ZxpTBCvcpjEmR4MaBjEns8/GH%23169---App-level-alert-text-alignment?node-id=102%3A34&t=mDZ5nxi3I7yLTgGq-1

kevinbuhmann commented 1 year ago

Sorry for the label and assignee churn above. I see now that the visual design still needs review.