search

vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.
https://clarity.design
MIT License
163 stars 42 forks source link

CdsButton attribute `loadingState` inconsistently sets `disabled` #172

Closed dturcotte closed 1 year ago

dturcotte commented 1 year ago

Describe the bug

a CdsButton whose loadingState starts as non-default remains disabled when switching back to default

How to reproduce

Codesandbox on 6.1.4

Steps to reproduce the behavior:

  1. See button whose loadingState starts as loading. Button is disabled
  2. Change loading state to default. Button remains disabled

Expected behavior

Button should no longer be disabled when loadingState is default

Versions

Clarity project:

Clarity version:

Framework:

Framework version: React 18

Device:

Additional notes

Related: https://github.com/vmware-clarity/core/issues/129

loadingState works as expected if the starting state is default

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 6.1.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.