vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.
https://clarity.design
MIT License
163 stars 42 forks source link

fix(button): buttons starting with loading-state should be come enabled after #173

Closed ashleyryan closed 1 year ago

ashleyryan commented 1 year ago

previous logic will restore a button to enabled when switching default -> loading/error -> default, but not if the button starts in a loadingState other than default

fixes #172

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

When a button goes from default/undefined loading state -> loading or error -> default, the button will go from enabled -> disabled -> enabled. However, this logic didn't work if the button starts in a non-default loadingState

Issue Number: #172

What is the new behavior?

Does this PR introduce a breaking change?

Other information

github-actions[bot] commented 1 year ago

👋 @ashleyryan,

Thank you,

🤖 Clarity Release Bot

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 6.1.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.