search

vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.
https://clarity.design
MIT License
163 stars 42 forks source link

cds-modal margin is off without cds-modal-actions #174

Closed ashleyryan closed 1 year ago

ashleyryan commented 1 year ago

Describe the bug

When using a cds-modal without cds-modal-actions (aka the footer), there's very little margin at the bottom of the modal.

This is in contrast to how clr-modal works without the footer class.

How to reproduce

https://stackblitz.com/edit/clarity-typescript-demo-i53agv?file=src%2Findex.html

Open the two modals and compare the margin at the bottom when using an empty cds-modal-actions vs not.

Compare with clr-ui: https://stackblitz.com/edit/clarity-dark-theme-clr13-cds6-dwvuvf?file=src%2Fapp%2Fapp.component.html

Expected behavior

The behavior should more closely match clr-ui where margin exists even without the actions at the bottom.

Versions

Clarity project:

Clarity version:

Framework:

Framework version: ie: Angular 11

Device:

Additional notes

Add any other notes about the problem here.

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 6.1.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.