vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.
https://clarity.design
MIT License
163 stars 42 forks source link

fix(dropdown): rename popup attribute to aria-controls #179

Closed ashleyryan closed 1 year ago

ashleyryan commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

The popup attribute conflicts with the Popup API that chromium has started implementing and results in errors logged in the console. See development status: https://chromestatus.com/feature/5463833265045504

Issue Number: #140

What is the new behavior?

This renames the attribute to aria-controls, which is semantically correct. This is a breaking change

Does this PR introduce a breaking change?

Applications will lose aria attribute setting if they don't rename the attribute in their code. The component is a beta components so this change should be acceptable.

Other information

github-actions[bot] commented 1 year ago

👋 @ashleyryan,

Thank you,

🤖 Clarity Release Bot

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 6.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.