Closed ashleyryan closed 1 year ago
👋 @ashleyryan,
Thank you,
🤖 Clarity Release Bot
:tada: This PR is included in version 6.2.0 :tada:
The release is available on:
v6.2.0
Your semantic-release bot :package::rocket:
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The popup attribute conflicts with the Popup API that chromium has started implementing and results in errors logged in the console. See development status: https://chromestatus.com/feature/5463833265045504
Issue Number: #140
What is the new behavior?
This renames the attribute to aria-controls, which is semantically correct. This is a breaking change
Does this PR introduce a breaking change?
Applications will lose aria attribute setting if they don't rename the attribute in their code. The component is a beta components so this change should be acceptable.
Other information