vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.
https://clarity.design
MIT License
163 stars 42 forks source link

fix(control): apply control action padding when visibility changes #184

Closed ashleyryan closed 1 year ago

ashleyryan commented 1 year ago

fixes #182

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

The padding is set for the control action only on the initial render, in firstUpdated. If the element is hidden at the time, the padding will be incorrect when the element becomes visible.

Issue Number: #182

What is the new behavior?

There's now an intersection observer listening for visibility changes that will set the padding correctly

Does this PR introduce a breaking change?

Other information

github-actions[bot] commented 1 year ago

πŸ‘‹ @ashleyryan,

Thank you,

πŸ€– Clarity Release Bot

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 6.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

Hi there πŸ‘‹, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.