vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.
https://clarity.design
MIT License
163 stars 42 forks source link

fix(modal): rerender modal when action slot is added #190

Closed ashleyryan closed 1 year ago

ashleyryan commented 1 year ago

fixes #188

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

When the actions are supplied asynchronously, they don't show up.

Issue Number: #188

What is the new behavior?

The slot is rendered all the time, just with a hidden attribute. A slot listener was added to make sure the component rerenders to remove the hidden attribute

Does this PR introduce a breaking change?

Other information

github-actions[bot] commented 1 year ago

๐Ÿ‘‹ @ashleyryan,

Thank you,

๐Ÿค– Clarity Release Bot

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 6.2.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

Hi there ๐Ÿ‘‹, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.