fix(shim): match light ng-clarity vertical nav background colors

vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.

https://clarity.design

MIT License

163 stars 42 forks source link

fix(shim): match light ng-clarity vertical nav background colors #197

Closed kevinbuhmann closed 1 year ago

kevinbuhmann commented 1 year ago

closes #195

PR Checklist

Please check if your PR fulfills the following requirements:

[N/A] Tests for the changes have been added (for bug fixes / features)
[N/A] Docs have been added / updated (for bug fixes / features)
[x] If applicable, have a visual design approval

PR Type

Fix (sort of)

What is the current behavior?

The light theme shim uses a lighter background color than ng-clarity for the vertical nav.

Issue Number: #195

What is the new behavior?

The light theme shim uses exactly the same background colors as ng-clarity for the vertical nav. Other themes are unaffected.

Does this PR introduce a breaking change?

github-actions[bot] commented 1 year ago

👋 @kevinbuhmann,

🙏 The Clarity team thanks you for opening a pull request
🎉 The build for this PR has succeeded
🔍 The PR is now ready for review
🍿 In the meantime, checkout out a preview of this PR
🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 6.2.3 :tada:

The release is available on:

GitHub release
v6.2.3

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.