fix(shim): add mappings for datagrid loading background color

vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.

https://clarity.design

MIT License

163 stars 42 forks source link

fix(shim): add mappings for datagrid loading background color #200

Closed kevinbuhmann closed 1 year ago

kevinbuhmann commented 1 year ago

PR Checklist

[N/A] Tests for the changes have been added (for bug fixes / features)
[N/A] Docs have been added / updated (for bug fixes / features)
[x] If applicable, have a visual design approval
- I worked with Colin on this.

PR Type

Bugfix

What is the current behavior?

The shim doesn't map the --clr-datagrid-loading-background color. This causes the ng-clarity light color to "leak" when using the cds dark theme.

What is the new behavior?

This shim maps the --clr-datagrid-loading-background to --cds-alias-object-opacity-100 and --cds-alias-object-opacity-300 for the light and dark theme, respectively.

Does this PR introduce a breaking change?

No.

github-actions[bot] commented 1 year ago

👋 @kevinbuhmann,

🙏 The Clarity team thanks you for opening a pull request
🎉 The build for this PR has succeeded
🔍 The PR is now ready for review
🍿 In the meantime, checkout out a preview of this PR
🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 6.2.4 :tada:

The release is available on:

GitHub release
v6.2.4

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.