vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.
https://clarity.design
MIT License
161 stars 42 forks source link

feat(accordion): add css custom properties #277

Closed yuhsianw closed 8 months ago

yuhsianw commented 8 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: https://github.com/vmware-clarity/core/issues/278

What is the new behavior?

--box-shadow, --icon-visibility, and --icon-margin CSS custom properties added to cds-accordion-header.

Does this PR introduce a breaking change?

Other information

vmwclabot commented 8 months ago

@yuhsianw, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

github-actions[bot] commented 8 months ago

👋 @yuhsianw,

Thank you,

🤖 Clarity Release Bot

vmwclabot commented 8 months ago

@yuhsianw, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

vmwclabot commented 8 months ago

@yuhsianw, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

VMware employees do not need to sign a CLA to have changes merged to a repository owned by a VMware organization. If you are a member of a VMware GitHub organization, you will not be prompted to sign a CLA when opening a pull request. If you are a VMware employee and you are prompted to sign a CLA, close the pull request where you are prompted to sign the CLA and navigate to VMware's internal Upstream Contrib and join the desired VMware organization. Accept the invitation to join the org & open a new PR.

yuhsianw commented 8 months ago

Closing PR following https://cla.vmware.com/employee

github-actions[bot] commented 7 months ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.