search

vmware-clarity / core

Clarity is a scalable, accessible, customizable, open-source design system built with web components. Works with any JavaScript framework, created for enterprises, and designed to be inclusive.
https://clarity.design
MIT License
161 stars 42 forks source link

Minor version introduces breaking changes to the build #318

Closed squidjam closed 3 weeks ago

squidjam commented 3 weeks ago

Describe the bug

a deprecation for default value means the rewrite of a lot of documentation. Minor revisions are not supposed to bring breaking changes. image

How to reproduce

Have defaultValue set up on your storybook stories, upgrade to 8.1, see it break when building.

Steps to reproduce the behavior:

Described them above

Expected behavior

Minor upgrades should not bring breaking changes or deprecations that break the build.

Versions

Clarity project:

Clarity version:

Framework:

Framework version: React 18.2.0

Device:

Additional notes

why would you push a deprecation for a feature that would break the build on a minor update? are you aware that now all our builds require to deal with this unforeseen change that cannot be planned? please, think about this changes and review how SEMVER works.

kevinbuhmann commented 3 weeks ago

Have defaultValue set up on your storybook stories, upgrade to 8.1, see it break when building.

Is this a Clarity Core issue or a Storybook issue? We haven't released a version 8.1 of Clarity Core.

squidjam commented 3 weeks ago

Apparently I managed to send reports to the wrong repository, my apologies

github-actions[bot] commented 1 week ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.