search

vmware-clarity / ng-clarity

Clarity Angular is a scalable, accessible, customizable, open-source design system built for Angular.
https://clarity.design
Other
319 stars 71 forks source link

Buttons placed within card body has no margins #1327

Open peer-kkang opened 3 months ago

peer-kkang commented 3 months ago

Describe the bug

Buttons placed inside Card body has no margins

How to reproduce

Steps to reproduce the behavior:

<div class="card"><div class="card-header">Card Title</div><div class="card-block"><button class="btn">Hello</button><button class="btn">World</button><div class="card-text">This is a sample card, use the correct button alignment.</div></div><div class="card-footer"><button class="btn btn-sm btn-link">Action</button></div></div> image

Expected behavior

A clear and concise description of what you expected to happen.

Versions

Clarity version:

Framework version: Reproducible on both Angular 15, 16_

Additional notes

Add any other notes about the problem here.

kevinbuhmann commented 3 months ago

@dtsanevmw: Could you look into this? This appears to be a regression introduced during the token migration.

The horizontal margin for buttons within card was removed here: https://github.com/vmware-clarity/ng-clarity/commit/d54ce51b3a91f5bd5896a3b9b0d98ab7678b14eb#diff-8d9f8e25f7a921c94ef885adeaa6f3397e352ab917785283f4b8d654d2ae3596L271