vmware-clarity / ng-clarity

Clarity Angular is a scalable, accessible, customizable, open-source design system built for Angular.
https://clarity.design
Other
349 stars 80 forks source link

Signpost getting closed when the signpost datagrid filter input clicked or custom select filter applied #1476

Closed Jayavarc closed 1 month ago

Jayavarc commented 4 months ago

Describe the bug

In Signpost datagrid filter, whenever we are clicking on input or selecting custom filter applied then it's getting closed automatically

How to reproduce

https://stackblitz.com/edit/clarity-dark-theme-clr13-cds6-wgg3em?file=src%2Fapp%2Fapp.component.html,src%2Fapp%2Fapp.component.ts here is my code snippet please verify the issue in this stackblitz code image image

Steps to reproduce the behavior:

  1. Go to DataGrid table click on any cell
  2. in the signpost click on filter
  3. and click on DataGrid filter input
  4. it gets closed automatically

Expected behavior

Signpost should not get closed automatically after clicking on DataGrid filter input or custom select input, it should allow user to add filter context or select multiple custom filter context

Versions

Clarity version:

"@cds/core": "^6.12.0", "@clr/angular": "^16.5.1", "@clr/ui": "^16.5.1",

Framework version: _ie: Angular 16

Device:

All

Additional notes

none

kumart-netapp commented 4 months ago

Can someone look into this? We are also facing same issue.

Jayavarc commented 3 months ago

@Daniel Tsanev can you please look into this issue

dtsanevmw commented 1 month ago

Hello,

We don't recommend nesting components in this specific way so we won't be able to look into that at the moment.

Regards, Daniel Tsanev

kumart-netapp commented 1 month ago

Hello,

We don't recommend nesting components in this specific way so we won't be able to look into that at the moment.

Regards, Daniel Tsanev

Sorry, I don't see any such guideline/restriction in documentation of Clarity.

valentin-mladenov commented 1 month ago

@kumart-netapp and @Jayavarc the signpost component is not designed for nesting a datagrid in it. Should be used with small amount of contextual help.

https://clarity.design/documentation/signpost

Signposts are displayed in a popover dialog box and contain contextual help or information.

Usage Use a signpost when you want to show a small amount of contextual help without taking the user out of the current context.

valentin-mladenov commented 1 month ago

@kumart-netapp and @Jayavarc if you search similar behaviour you can use modal as an alternative.

https://clarity.design/documentation/modal

github-actions[bot] commented 1 month ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.