search

vmware-clarity / ng-clarity

Clarity Angular is a scalable, accessible, customizable, open-source design system built for Angular.
https://clarity.design
Other
341 stars 78 forks source link

Icons in navigation links have wrong color #1602

Open repolevedavaj opened 1 week ago

repolevedavaj commented 1 week ago

This is a bug report for the @clr Angular or UI versions of the design system. For the web-component implementation of Clarity (@cds), visit vmware-clarity/core.

If you are a VMware employee or a contractor in VMware, please use our support space in Google Chat to raise Clarity issues.

Describe the bug

In #1554, the icon color has been set to the link color, but in case of links in a navigation, a different color applies (--clr-nav-link-active-color). Therefore the icons get now styled with a wrong color: image

Expected behavior

Icons in navigation links should keep color --clr-nav-link-active-color.

Versions

Clarity version:

v17.3.1

kumart-netapp commented 1 week ago

After upgrading to latest version(17.3.1), the vertical nav icon colors are changed to blue if you visit the nav once. It should be grey.

image In the above image, Normal, Electric is blue as I had visited them at least once.

Link: https://stackblitz.com/edit/kjoau7?file=package.json

valentin-mladenov commented 1 week ago

@repolevedavaj and @kumart-netapp thank you for reporting this find.

We will investigate it in details and come back to you.