vmware-clarity / ng-clarity

Clarity Angular is a scalable, accessible, customizable, open-source design system built for Angular.
https://clarity.design
Other
347 stars 79 forks source link

In dark mode, datagrid loading has a margin top #578

Open esoubiran-aneo opened 1 year ago

esoubiran-aneo commented 1 year ago

This is a bug report for the @clr Angular or UI versions of the design system. For the web-component implementation of Clarity (@cds), visit vmware-clarity/core.

Describe the bug

A clear and concise description of what the bug is, and the conditions when it occurs.

In dark mode, when the datagrid load data, the dimed background has more height than the datagrid.

image

How to reproduce

Please provide a link to a reproduction scenario using one of the Clarity Stackblitz templates. Reports without a clear reproduction may not be prioritized until one is provided.

Steps to reproduce the behavior:

  1. Add a datagrid to a page
  2. Setup clrDgLoading to true

Expected behavior

I expected the dimed to be only on the datagrid.

Versions

Clarity version:

Framework version:

Angular 13

Device:

Additional notes

Add any other notes about the problem here.

williamernest commented 1 year ago

It's in both light and dark modes. Not sure why it's there. We'll look into it and remove it if possible.

biswasSaumyadip commented 1 year ago

@williamernest why there is a margin-top of .6rem, seems unnecessary.