search

vmware-labs / distribution-tooling-for-helm

Helm Distribution plugin is is a set of utilities and Helm Plugin for making offline work with Helm Charts easier. It is meant to be used for creating reproducible and relocatable packages for Helm Charts that can be moved around registries without hassles. This is particularly useful for distributing Helm Charts into airgapped environments.
Apache License 2.0
74 stars 12 forks source link

Remove non-required `ClientOptResolver` option usage #55

Closed antgamdia closed 4 months ago

antgamdia commented 8 months ago

In Kubeapps, we needed to add a new ClientOptResolveroption in the Helm project (context here). However, this is mostly for tests and other non-typical use-cases. The current NewClient function in Helm is setting the required options in the autorizer, so there is no need to manually set the resolver (see the code)

This PR is mainly remove those redundant piece of code, so that ClientOptResolver is not used anymore.

The rationale behind the change is in https://github.com/helm/helm/pull/12310#discussion_r1501065719. In short, this is blocking a potential upgrade from ORAS v1 to v2 at Helm's side.

antgamdia commented 8 months ago

ping @juamedgod / @alemorcuq :P

Edit: as per an offline sync, they will go ahead with the change if Helm decides to effectively migrate to ORAS v2.