search

vmware-labs / distribution-tooling-for-helm

Helm Distribution plugin is is a set of utilities and Helm Plugin for making offline work with Helm Charts easier. It is meant to be used for creating reproducible and relocatable packages for Helm Charts that can be moved around registries without hassles. This is particularly useful for distributing Helm Charts into airgapped environments.
Apache License 2.0
71 stars 12 forks source link

This branch adds support for nested helm dependencies #71

Closed shortwavedave closed 1 month ago

shortwavedave commented 3 months ago

The previous implementation had a recursive function but it terminated after one level This branch adds support for nested repository urls - the previous implementation only supported a single level

Resolves: #67

mpermar commented 2 months ago

Actually @shortwavedave I've been testing the relocation with your branch and it indeeds solves the problems with nested Helm charts, but it seems it causes some regressions. This PR was going to need a rebase anyways. Are you interested in driving this one forward?

shortwavedave commented 2 months ago

@mpermar thanks for reviewing - I thought I had run the tests in the repository. I can drive forward - could you share what regressions you see please?

shortwavedave commented 2 months ago

oh I see the checks that have failed in this PR - ok I'll take a look

vmwclabot commented 2 months ago

@shortwavedave, VMware has approved your signed contributor license agreement.

mpermar commented 1 month ago

@shortwavedave closing in favor of #83. Really appreciated the heads up and contribution.