search

vmware-labs / distribution-tooling-for-helm

Helm Distribution plugin is is a set of utilities and Helm Plugin for making offline work with Helm Charts easier. It is meant to be used for creating reproducible and relocatable packages for Helm Charts that can be moved around registries without hassles. This is particularly useful for distributing Helm Charts into airgapped environments.
Apache License 2.0
71 stars 12 forks source link

Support `helm.sh/images` as annotation to list Helm chart images #74

Closed FraPazGal closed 3 months ago

FraPazGal commented 3 months ago

Is your feature request related to a problem? Please describe.

Trying to create an images lock will not produce the expected result if the annotation used to list the Helm chart images is different from images. This goes against HIP-0015, which establishes the annotation helm.sh/images as a future standard.

Describe the solution you'd like

For dt to support the usage of any of the two images or helm.sh/images annotations.

Describe alternatives you've considered

Using the currently supported images annotation works as expected but it would be preferable to be able to use helm.sh/images as defined by HIPs.

Additional context

No response

mpermar commented 3 months ago

Hey @FraPazGal . Have you tried with the --annotations-key flag?

FraPazGal commented 3 months ago

That works perfectly, thanks for the help @mpermar!