search

vmware-labs / marketplace-cli

A CLI for interacting with the VMware Marketplace
Other
11 stars 2 forks source link

Setting OSL is global, not versioned. #83

Closed petewall closed 2 years ago

petewall commented 2 years ago

I noticed here: https://stg.market.csp.vmware.com/services/details/test-iso-product1?slug=true&serviceMgmt=true

That all versions have the OSL that ends with osl-0.1.30.txt, meaning the product set command is not setting the OSL per version. We need to:

  1. Fix the functionality so it's versioned
  2. Add appropriate testing, at least to the pipeline, so it catches this.
petewall commented 2 years ago

c59fd7d aims to catch this in the pipeline tests.

petewall commented 2 years ago

Tests are failing properly now: https://runway-ci.eng.vmware.com/teams/tanzu-isv-engineering/pipelines/marketplace-cli/jobs/test-publish-ova-product/builds/70

Catching the failures in the pipeline will now validate that the fix works and stays working.