vmware-labs / reconciler-runtime

⚠️ Maintenance suspended. Please, migrate to the active fork reconciler.io/runtime. See https://github.com/reconcilerio/runtime/releases/tag/v0.20.0 for instructions. This repository will be archived eventually.
Other
81 stars 18 forks source link

Fix concatenated log context in Sequence #412

Closed cjnosal closed 11 months ago

cjnosal commented 11 months ago

Each child reconciler was receiving the accumulated log context of all prior children in the Sequence

Before:

INFO MyResourceReconciler.0.MyChildSetReconciler.0.id $msg
INFO MyResourceReconciler.0.MyChildSetReconciler.0.1.id $msg
INFO MyResourceReconciler.0.MyChildSetReconciler.0.1.2.id $msg

After:

INFO MyResourceReconciler.0.MyChildSetReconciler.0.id $msg
INFO MyResourceReconciler.0.MyChildSetReconciler.1.id $msg
INFO MyResourceReconciler.0.MyChildSetReconciler.2.id $msg
codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0ced1f4) 60.62% compared to head (4768e6c) 60.62%.

:exclamation: Current head 4768e6c differs from pull request most recent head fbed359. Consider uploading reports for the commit fbed359 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #412 +/- ## ======================================= Coverage 60.62% 60.62% ======================================= Files 24 24 Lines 2334 2334 ======================================= Hits 1415 1415 Misses 835 835 Partials 84 84 ``` | [Files Changed](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs) | Coverage Δ | | |---|---|---| | [reconcilers/sequence.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvc2VxdWVuY2UuZ28=) | `55.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

scothis commented 11 months ago

Good catch. Thanks