vmware-labs / reconciler-runtime

⚠️ Maintenance suspended. Please, migrate to the active fork reconciler.io/runtime. See https://github.com/reconcilerio/runtime/releases/tag/v0.20.0 for instructions. This repository will be archived eventually.
Other
81 stars 18 forks source link

Allow ChildReconciler to reflect invalid api errors #418

Closed scothis closed 11 months ago

scothis commented 11 months ago

API errors with an "invalid" response from the server are now passed to ReflectChildStatusOnParent. They can be detected with:

apierrs.IsInvalid(err)
codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10% :tada:

Comparison is base (55557b2) 60.62% compared to head (337f7ed) 60.72%. Report is 1 commits behind head on main.

:exclamation: Current head 337f7ed differs from pull request most recent head b1ccf59. Consider uploading reports for the commit b1ccf59 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #418 +/- ## ========================================== + Coverage 60.62% 60.72% +0.10% ========================================== Files 24 24 Lines 2334 2340 +6 ========================================== + Hits 1415 1421 +6 Misses 835 835 Partials 84 84 ``` | [Files Changed](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/418?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs) | Coverage Δ | | |---|---|---| | [reconcilers/childset.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/418?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvY2hpbGRzZXQuZ28=) | `87.87% <ø> (ø)` | | | [reconcilers/child.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/418?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvY2hpbGQuZ28=) | `84.50% <100.00%> (+0.68%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.