vmware-labs / reconciler-runtime

⚠️ Maintenance suspended. Please, migrate to the active fork reconciler.io/runtime. See https://github.com/reconcilerio/runtime/releases/tag/v0.20.0 for instructions. This repository will be archived eventually.
Other
81 stars 18 forks source link

Track managed resources when update is skipped #421

Closed scothis closed 11 months ago

scothis commented 11 months ago

Tracked resources need to be refreshed on each reconcile request. Previously, the ResourceManager would only track resource when they are created or updated. Now it will always track existing resources and will not be skipped when the update is skipped because the resource is in sync.

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 33.33% and no project coverage change.

Comparison is base (919abf6) 60.78% compared to head (e123106) 60.78%.

:exclamation: Current head e123106 differs from pull request most recent head 718d307. Consider uploading reports for the commit 718d307 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #421 +/- ## ======================================= Coverage 60.78% 60.78% ======================================= Files 25 25 Lines 2494 2494 ======================================= Hits 1516 1516 Misses 893 893 Partials 85 85 ``` | [Files Changed](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs) | Coverage Δ | | |---|---|---| | [reconcilers/resourcemanager.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvcmVzb3VyY2VtYW5hZ2VyLmdv) | `78.26% <33.33%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.