vmware-labs / reconciler-runtime

⚠️ Maintenance suspended. Please, migrate to the active fork reconciler.io/runtime. See https://github.com/reconcilerio/runtime/releases/tag/v0.20.0 for instructions. This repository will be archived eventually.
Other
81 stars 18 forks source link

Allow errors to be quiet #429

Closed scothis closed 10 months ago

scothis commented 10 months ago

ErrQuiet errors are not logged within reconciler-runtime and do not trigger events to be recorded. This behavior is conventional rather than technical. An implementor may choose to ignore these conventions when it fits their purpose. Quite is not silent.

Also redefines ErrHaltSubReconcilers to wrap ErrQuiet. HaltSubReconcilers is deprecated in favor of ErrHaltSubReconcilers.

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 91.11% and project coverage change: +0.19% :tada:

Comparison is base (ce2ead6) 60.89% compared to head (a6194fe) 61.09%.

:exclamation: Current head a6194fe differs from pull request most recent head 8063046. Consider uploading reports for the commit 8063046 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #429 +/- ## ========================================== + Coverage 60.89% 61.09% +0.19% ========================================== Files 26 26 Lines 2514 2529 +15 ========================================== + Hits 1531 1545 +14 - Misses 896 898 +2 + Partials 87 86 -1 ``` | [Files Changed](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs) | Coverage Δ | | |---|---|---| | [reconcilers/reconcilers.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvcmVjb25jaWxlcnMuZ28=) | `73.07% <0.00%> (-0.71%)` | :arrow_down: | | [reconcilers/resourcemanager.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvcmVzb3VyY2VtYW5hZ2VyLmdv) | `78.99% <85.71%> (+0.73%)` | :arrow_up: | | [reconcilers/aggregate.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvYWdncmVnYXRlLmdv) | `61.15% <100.00%> (+0.32%)` | :arrow_up: | | [reconcilers/child.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvY2hpbGQuZ28=) | `84.72% <100.00%> (+0.21%)` | :arrow_up: | | [reconcilers/finalizer.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvZmluYWxpemVyLmdv) | `81.15% <100.00%> (+0.27%)` | :arrow_up: | | [reconcilers/resource.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvcmVzb3VyY2UuZ28=) | `74.48% <100.00%> (+0.39%)` | :arrow_up: | | [reconcilers/sync.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvc3luYy5nbw==) | `78.43% <100.00%> (+0.88%)` | :arrow_up: | | [reconcilers/webhook.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvd2ViaG9vay5nbw==) | `90.47% <100.00%> (+0.09%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.