vmware-labs / reconciler-runtime

⚠️ Maintenance suspended. Please, migrate to the active fork reconciler.io/runtime. See https://github.com/reconcilerio/runtime/releases/tag/v0.20.0 for instructions. This repository will be archived eventually.
Other
81 stars 18 forks source link

Capture resourceType GVK in logs for duck types #430

Closed scothis closed 1 year ago

scothis commented 1 year ago

Reconcilers using duck type will now include the correct resourceType metadata in logs. Previously it was an empty GVK.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 63.63% and project coverage change: -0.08% :warning:

Comparison is base (ce2ead6) 60.89% compared to head (7f2b6ab) 60.81%.

:exclamation: Current head 7f2b6ab differs from pull request most recent head 41a88b6. Consider uploading reports for the commit 41a88b6 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #430 +/- ## ========================================== - Coverage 60.89% 60.81% -0.08% ========================================== Files 26 26 Lines 2514 2514 ========================================== - Hits 1531 1529 -2 - Misses 896 897 +1 - Partials 87 88 +1 ``` | [Files Changed](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs) | Coverage Δ | | |---|---|---| | [reconcilers/childset.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvY2hpbGRzZXQuZ28=) | `87.87% <0.00%> (ø)` | | | [reconcilers/aggregate.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvYWdncmVnYXRlLmdv) | `60.83% <50.00%> (ø)` | | | [reconcilers/child.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvY2hpbGQuZ28=) | `84.50% <50.00%> (ø)` | | | [reconcilers/resource.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvcmVzb3VyY2UuZ28=) | `74.09% <50.00%> (ø)` | | | [reconcilers/cast.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvY2FzdC5nbw==) | `75.00% <100.00%> (ø)` | | | [reconcilers/reconcilers.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvcmVjb25jaWxlcnMuZ28=) | `71.84% <100.00%> (-1.95%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.