vmware-labs / reconciler-runtime

⚠️ Maintenance suspended. Please, migrate to the active fork reconciler.io/runtime. See https://github.com/reconcilerio/runtime/releases/tag/v0.20.0 for instructions. This repository will be archived eventually.
Other
81 stars 18 forks source link

Streamline finalizer patching #434

Closed scothis closed 10 months ago

scothis commented 10 months ago

Since the client can now handle duck type resources, we no longer need to cast the current resources back to the parent resource type.

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.29% :warning:

Comparison is base (d7f3909) 61.01% compared to head (54c2a3e) 60.72%.

:exclamation: Current head 54c2a3e differs from pull request most recent head e86fc5a. Consider uploading reports for the commit e86fc5a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #434 +/- ## ========================================== - Coverage 61.01% 60.72% -0.29% ========================================== Files 26 26 Lines 2529 2518 -11 ========================================== - Hits 1543 1529 -14 - Misses 899 902 +3 Partials 87 87 ``` | [Files Changed](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs) | Coverage Δ | | |---|---|---| | [reconcilers/finalizer.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvZmluYWxpemVyLmdv) | `84.48% <100.00%> (+3.32%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/434/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.