search

vmware-labs / reconciler-runtime

⚠️ Maintenance suspended. Please, migrate to the active fork reconciler.io/runtime. See https://github.com/reconcilerio/runtime/releases/tag/v0.20.0 for instructions. This repository will be archived eventually.
Other
81 stars 18 forks source link

Draft: duck type support for builder calls - still need to deal with client.… #450

Closed squeedee closed 8 months ago

squeedee commented 8 months ago

…Create not working

codecov[bot] commented 8 months ago

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (c994cf2) 60.65% compared to head (7ce0492) 60.41%.

:exclamation: Current head 7ce0492 differs from pull request most recent head 4131229. Consider uploading reports for the commit 4131229 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #450 +/- ## ========================================== - Coverage 60.65% 60.41% -0.24% ========================================== Files 26 26 Lines 2524 2534 +10 ========================================== Hits 1531 1531 - Misses 904 914 +10 Partials 89 89 ``` | [Files](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs) | Coverage Δ | | |---|---|---| | [reconcilers/child.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvY2hpbGQuZ28=) | `79.22% <0.00%> (-5.51%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

scothis commented 8 months ago

Duck types are inherently interfaces that project a subset of a resource. Thus they cannot be used in places where a fully defined resource is required. Like Create and Update operations.

This behavior is documented at the top of the readme