search

vmware-labs / reconciler-runtime

⚠️ Maintenance suspended. Please, migrate to the active fork reconciler.io/runtime. See https://github.com/reconcilerio/runtime/releases/tag/v0.20.0 for instructions. This repository will be archived eventually.
Other
81 stars 18 forks source link

Enable testing SubReconcilers with duck typed resources #454

Closed scothis closed 8 months ago

scothis commented 8 months ago

The Resource is now converted to an unstructured before being set as a given on the fake client. Previously it would panic because the duck was not registered on the scheme (which it should not be).

codecov[bot] commented 8 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (e19c127) 60.68% compared to head (b586df9) 60.54%.

:exclamation: Current head b586df9 differs from pull request most recent head ddfd714. Consider uploading reports for the commit ddfd714 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #454 +/- ## ========================================== - Coverage 60.68% 60.54% -0.15% ========================================== Files 26 26 Lines 2526 2532 +6 ========================================== Hits 1533 1533 - Misses 904 910 +6 Partials 89 89 ``` | [Files](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs) | Coverage Δ | | |---|---|---| | [testing/subreconciler.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-dGVzdGluZy9zdWJyZWNvbmNpbGVyLmdv) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.