search

vmware-labs / reconciler-runtime

⚠️ Maintenance suspended. Please, migrate to the active fork reconciler.io/runtime. See https://github.com/reconcilerio/runtime/releases/tag/v0.20.0 for instructions. This repository will be archived eventually.
Other
81 stars 18 forks source link

demonstration of a possible oversight #456

Closed squeedee closed 8 months ago

squeedee commented 8 months ago

Just wonder if this layering (through a shadowed ctx) was intentional or an oversight?

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d4d2708) 60.54% compared to head (72f8a95) 60.54%.

:exclamation: Current head 72f8a95 differs from pull request most recent head a24f659. Consider uploading reports for the commit a24f659 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #456 +/- ## ======================================= Coverage 60.54% 60.54% ======================================= Files 26 26 Lines 2532 2532 ======================================= Hits 1533 1533 Misses 910 910 Partials 89 89 ``` | [Files](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/456?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs) | Coverage Δ | | |---|---|---| | [reconcilers/sequence.go](https://app.codecov.io/gh/vmware-labs/reconciler-runtime/pull/456?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-labs#diff-cmVjb25jaWxlcnMvc2VxdWVuY2UuZ28=) | `55.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

scothis commented 8 months ago

Intentional, see https://github.com/vmware-labs/reconciler-runtime/pull/412