search

vmware-labs / reconciler-runtime

⚠️ Maintenance suspended. Please, migrate to the active fork reconciler.io/runtime. See https://github.com/reconcilerio/runtime/releases/tag/v0.20.0 for instructions. This repository will be archived eventually.
Other
81 stars 18 forks source link

Allow access to known children in ChildSetReconciler#DesiredChildren #458

Closed scothis closed 7 months ago

scothis commented 8 months ago

Current known children can be obtained via RetrieveKnownChildren(ctx). This can be used to keep existing children while stamping out new resources, or for garbage collecting resources based on some criteria. Return the children that should be kept and omit children to delete.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e002cf4) 60.54% compared to head (a8abd38) 60.67%.

Files Patch % Lines
reconcilers/childset.go 94.11% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #458 +/- ## ========================================== + Coverage 60.54% 60.67% +0.13% ========================================== Files 26 26 Lines 2532 2543 +11 ========================================== + Hits 1533 1543 +10 - Misses 910 911 +1 Partials 89 89 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.