Closed scothis closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
e22ffba
) 60.67% compared to head (23afd45
) 61.02%. Report is 16 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@scothis, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.
@neowulf can you give this branch a try?
@neowulf can you give this branch a try?
Because personally I can never recall the correct incantation, this may help:
go mod edit -replace github.com/vmware-labs/reconciler-runtime=github.com/scothis/reconciler-runtime@object-list-pointer
go mod tidy
Thank you for the quick response! Yes, this patch works!
@scothis, VMware has approved your signed contributor license agreement.
Canonically, Items in an ObjectList are a slice of structs. Some types, like Istio, use a slice of pointers intead. We now detect and handle both.
Resolves #479