search

vmware-labs / yaml-jsonpath

JSONPath implementation for the gopkg.in/yaml.v3 node API
Other
49 stars 12 forks source link

feat: add propertyName operator #45

Closed JefeDavis closed 3 years ago

JefeDavis commented 3 years ago

add operator to return the property name of a search instead of the value

closes #44

Signed-off-by: Jeff Davis jeffda@vmware.com

JefeDavis commented 3 years ago

code coverage at 95.8%

JefeDavis commented 3 years ago

@glyn not sure what you mean by the fuzz testing, but i believe i handled all of your comments that you left

glyn commented 3 years ago

@glyn not sure what you mean by the fuzz testing, but i believe i handled all of your comments that you left

Fuzz testing is mentioned in the project README and is described in detail here. If you run the fuzz tests for a few minutes, the fuzzer may find issues with this PR.

Update: I ran the fuzz tests for a few minutes and no crashes were found.

glyn commented 3 years ago

This PR changes the behaviour of the project in a backward incompatible, albeit minor, way. Please add a test to document this change, such as https://github.com/JefeDavis/yaml-jsonpath/pull/1.

JefeDavis commented 3 years ago

@glyn if you are ok with it I'm going to merge this today

JefeDavis commented 3 years ago

@glyn I will tag off the previous version as v0.1.0 and tag this one as v0.2.0 since we haven't actually published a v1.0.0 i don't think we need to worry about the minor backwards compatibility change, it is already documented that the dotchild has a restricted character set

glyn commented 3 years ago

Sure. Semver allows incompatible changes in the v0.x sequence.

On Thu, 29 Apr 2021, 20:03 Jeff Davis, @.***> wrote:

@glyn https://github.com/glyn I will tag off the previous version as v0.1.0 and tag this one as v0.2.0 since we haven't actually published a v1.0.0 i don't think we need to worry about the minor backwards compatibility change, it is already documented that the dotchild has a restricted character set

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vmware-labs/yaml-jsonpath/pull/45#issuecomment-829511977, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXF2MYQ6EZ67BFCNYDB6TTLGUQTANCNFSM43NUML6A .

ahuffman commented 3 years ago

@glyn thanks again for working with us on this! Good to get the original author's buy-in :). Cheers!

glyn commented 3 years ago

You're welcome @ahuffman.