vmware-samples / vcenter-event-broker-appliance

The VMware Event Broker Appliance Fling enables customers to unlock the hidden potential of events in their SDDC to easily create event-driven automation.
Other
157 stars 68 forks source link

fix: Add Broadcom OneTrust Cookie script for compliance #1223

Closed lamw closed 6 months ago

lamw commented 6 months ago

Summary

This change adds the required OneTrust cookie script to meet Broadcom cookie compliance. It was also recommended to remove the old Google Analytics as the version is outdated.

Pull Request Checklist

🚨 Please review the guidelines for contributing to this repository.

Change Type

What types of changes does your code introduce to the VMware Event Broker Appliance?

Put an x in all boxes that apply

Please check the type of change your PR introduces:

Resolved Issues

List of Issues closed or resolved by this PR. Add multiple Closes keyword followed by the issue number (e.g. Closes #ISSUE-NUMBER)

Closes #1222

Testing Verification

Additional Information

If you have any questions/comments, feel free to reach out to team on Slack #vcenter-event-broker-appliance

Thank you from the VEBA Team! 🥳

lamw commented 6 months ago

Just making sure - Is removing the google analytics line intentional?

It's cleaner to remove the analytics from

https://github.com/vmware-samples/vcenter-event-broker-appliance/blob/49a6be9ba74b0fac831babbddbb171e4e2781aea/docs/_config.yml#L21

Yup, this was intentional per internal review as the Google Analytics snippet was out of date and would require additional changes if we wish to keep it