search

vmware-tanzu-labs / educates-training-platform

A platform for hosting interactive workshop environments in Kubernetes, or on top of a local container runtime.
https://docs.educates.dev
Apache License 2.0
63 stars 15 forks source link

Local deletion of educates-installer directory. #411

Closed GrahamDumpleton closed 3 weeks ago

GrahamDumpleton commented 3 weeks ago

Describe the bug

In Makefile has:

deploy-installer:
ifneq ("$(wildcard developer-testing/educates-installer-values.yaml)","")
    kubectl create ns educates-installer || true
    ytt --file carvel-packages/installer/bundle/config --data-values-file developer-testing/educates-installer-values.yaml | kapp deploy -a label:installer=educates-installer.app -n educates-installer -f - -y
else
    kubectl create ns educates-installer || true
    ytt --file carvel-packages/installer/bundle/config | kapp deploy -a label:installer=educates-installer.app -n educates-installer -f - -y
endif

delete-installer:
    kapp delete -a educates-installer -y

Thus deploy target creates educates-installer namespace, but delete target doesn't remove the namespace.

The deploy target is tolerant of the namespace already existing, but should the delete target still delete the namespace?

Additional information

No response