search

vmware-tanzu-labs / educates-training-platform

A platform for hosting interactive workshop environments in Kubernetes, or on top of a local container runtime.
https://docs.educates.dev
Apache License 2.0
63 stars 14 forks source link

The changeOrigin option for ingress has been lost from Workshop CRD. #442

Closed GrahamDumpleton closed 2 weeks ago

GrahamDumpleton commented 2 weeks ago

Describe the bug

Documentation says one can set changeOrigin for an ingress:

spec:
  session:
    ingresses:
    - name: application
      protocol: http
      host: service.$(session_namespace).svc.$(cluster_domain)
      changeOrigin: false
      port: 8080

This is rejected though because changeOrigin is missing from the Workshop CRD.

The code in the dashboard session proxy does actually support changeOrigin, so the property has been lost from the CRD at some point.

Additional information

No response