vmware-tanzu-labs / educates-training-platform

A platform for hosting interactive workshop environments in Kubernetes, or on top of a local container runtime.
https://docs.educates.dev
Apache License 2.0
63 stars 14 forks source link

Local secrets enabled when no config #457

Closed jorgemoralespou closed 1 week ago

jorgemoralespou commented 1 week ago

By default if the user has not explicitly set --with-local-secrets with any value and config is not provided, it will enable local-secrets feature for create-cluster command. Closes #432

netlify[bot] commented 1 week ago

Deploy Preview for educates-docs canceled.

Built without sensitive environment variables

Name Link
Latest commit cd737041829e52f875859b541ca6f529e35351e5
Latest deploy log https://app.netlify.com/sites/educates-docs/deploys/6671d112e477b40008c2a5c5
GrahamDumpleton commented 1 week ago

Is this superseded by https://github.com/vmware-tanzu-labs/educates-training-platform/pull/461

jorgemoralespou commented 1 week ago

Yes