search

vmware-tanzu / asset-relocation-tool-for-kubernetes

A tool for relocating Kubernetes Assets
Other
42 stars 5 forks source link

feat: container keychains exclusion #138

Closed migmartri closed 2 years ago

migmartri commented 2 years ago

This patch changes the current containers authentication mechanism so instead of falling back to the default keychain, its use must be explicitly set.

The reason for this change is because while using relok8s as a library from charts-syncer I noticed that the fallback didn't make sense in that tool and there was not an easy way to disable it without providing bogus credentials, which also broke anonymous access to public registries.

From the POV of relok8s, nothing has changed, the CLI itself indicates that it wants to use the local keychain

vmwclabot commented 2 years ago

@migmartri, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.